This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25464 ) Change subject: refactor stat_item: get rid of FIFO and "skipped" error ...................................................................... Patch Set 3: > Patch Set 3: > > > Patch Set 3: > > > > I think those fields are mostly aimed at internal use by stats reporter, and I don't think anyone should be using those directly out of libosmocore. > > well, "think" and "should" is the problem: it is public API and this patch breaks it. > > This is a case of deciding to break an axiomatic principle because we're pretty sure to get away with it. > It really seems ok to do it, but it's objectively wrong from the underlying libosmo* release principles. > I'd like to have Harald's opinion on that. I fully agree with neels' analysis - but indeed for pragmatic reasons I think we can get away with it. We are not aware of any other substantial libosmocore users out there, and even if there are, it is hightly unlikely that they are using stuff that even we did never really use the way it was intended (the fifo history for stat_items). So yes, it's against our general API comptibility rules, but without even knowing a single example of code that would break it's hard to justify the extra complexity that goes along with maintaining both and old and a new API. So I don't have a general problem with the approach the patch takes, obviously just as long as old osmo-* still builds against libosmocore master. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25464 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I137992a5479fc39bbceb6c6c2af9c227bd33b39b Gerrit-Change-Number: 25464 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-CC: osmith <osmith at sysmocom.de> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 23 Sep 2021 13:02:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210923/5f3b8ae3/attachment.htm>