This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
osmith gerrit-no-reply at lists.osmocom.orgosmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/25548 )
Change subject: card_handler: make reader (sl) operations optional.
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/c/pysim/+/25548/1/pySim/card_handler.py
File pySim/card_handler.py:
https://gerrit.osmocom.org/c/pysim/+/25548/1/pySim/card_handler.py@38
PS1, Line 38: print("Ready for Programming: Insert card now (or CTRL-C to cancel)")
Does it make sense to print this message, when sl is not set? It looks like it makes more sense to move it into the "if self.sl".
I'm not sure how this will be used without the sl, but maybe it also makes sense to add "else" and print a message that this got skipped?
Same below for CardHandlerAuto.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/25548
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I0f793aec51751b7c7b87d55b66326cce9970274e
Gerrit-Change-Number: 25548
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Thu, 23 Sep 2021 12:44:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210923/8c48c135/attachment.htm>