This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25544 ) Change subject: abis: Fix memory leak of bts->osmo_link upon link going down ...................................................................... abis: Fix memory leak of bts->osmo_link upon link going down Commit below (see "Fixes" section) wrongly erased the code re-introduced in this commit, due to not spotting different between "oml_link" and "osmo_link". This commit is hence a revert of such commit, updated to current code. Fixes: c2ba34d9c13d309926c760943a9531fd3b236189 Change-Id: Id436116e5cd0bec024b2f9943fbff8d0bdc956ac --- M src/common/abis.c 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/common/abis.c b/src/common/abis.c index 3451b2e..93635c2 100644 --- a/src/common/abis.c +++ b/src/common/abis.c @@ -102,6 +102,13 @@ bts->oml_link = NULL; } memset(&bts->oml_conn_established_timestamp, 0, sizeof(bts->oml_conn_established_timestamp)); + + /* Same for IPAC_PROTO_OSMO on the same ipa connection: */ + if (bts->osmo_link) { + e1inp_sign_link_destroy(bts->osmo_link); + bts->osmo_link = NULL; + } + } static int pick_next_bsc(struct osmo_fsm_inst *fi) -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25544 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id436116e5cd0bec024b2f9943fbff8d0bdc956ac Gerrit-Change-Number: 25544 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210923/1bf9559c/attachment.htm>