Change in osmo-bts[master]: abis: Call bts_model_abis_close() when Abis link goes down

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Sep 23 12:07:31 UTC 2021


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25532 )

Change subject: abis: Call bts_model_abis_close() when  Abis link goes down
......................................................................

abis: Call bts_model_abis_close() when  Abis link goes down

This way based on BTS model features it can attempt to reconnect or
simply exit the process.

Change-Id: I42b43a0128bd4b579d9695e6dd2bccf6dc7e1d41
---
M src/common/abis.c
1 file changed, 3 insertions(+), 7 deletions(-)

Approvals:
  laforge: Looks good to me, but someone else must approve
  fixeria: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/common/abis.c b/src/common/abis.c
index 8e713d2..1722f3d 100644
--- a/src/common/abis.c
+++ b/src/common/abis.c
@@ -215,12 +215,8 @@
 			trx->rsl_link = NULL;
 		}
 	}
-
-	/* Note: if there was an OML or RSL connection present (the BTS was connected to a BSC). Then we will not try
-	 * to connect to an alternate BSC. Instead we will shut down the BTS process. This will ensure that all states
-	 * in the BTS (hardware and software) are reset properly. It is then up to the process management of the host
-	 * to restart osmo-bts. */
-	osmo_fsm_inst_state_chg(fi, ABIS_LINK_ST_FAILED, 0, 0);
+	bts_model_abis_close(bts);
+	osmo_fsm_inst_state_chg(fi, ABIS_LINK_ST_WAIT_RECONNECT, OML_RETRY_TIMER, 0);
 }
 
 static void abis_link_failed_onenter(struct osmo_fsm_inst *fi, uint32_t prev_state)
@@ -284,7 +280,7 @@
 		.in_event_mask =
 			S(ABIS_LINK_EV_SIGN_LINK_DOWN),
 		.out_state_mask =
-			S(ABIS_LINK_ST_FAILED),
+			S(ABIS_LINK_ST_WAIT_RECONNECT),
 		.onenter = abis_link_connected_onenter,
 		.action = abis_link_connected,
 	},

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25532
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I42b43a0128bd4b579d9695e6dd2bccf6dc7e1d41
Gerrit-Change-Number: 25532
Gerrit-PatchSet: 6
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210923/4afe6944/attachment.htm>


More information about the gerrit-log mailing list