Change in osmo-bts[master]: nm_bts_fsm: Make sure PHYs are opened when SW_ACTivating it

[pespin]

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25530 )

Change subject: nm_bts_fsm: Make sure PHYs are opened when SW_ACTivating it
......................................................................

nm_bts_fsm: Make sure PHYs are opened when SW_ACTivating it

Since recently we support shutting down phys when BTS goes into shutdown
mode. Let's make sure they are opened again when we connect again to the
BSC.

Change-Id: Ia1df6f4a1e0e6daeffe7303d518776a04b023930
---
M src/common/nm_bts_fsm.c
1 file changed, 13 insertions(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, but someone else must approve
  fixeria: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/common/nm_bts_fsm.c b/src/common/nm_bts_fsm.c
index 54737bf..bad533f 100644
--- a/src/common/nm_bts_fsm.c
+++ b/src/common/nm_bts_fsm.c
@@ -65,10 +65,23 @@
 static void st_op_disabled_notinstalled(struct osmo_fsm_inst *fi, uint32_t event, void *data)
 {
 	struct gsm_bts *bts = (struct gsm_bts *)fi->priv;
+	struct gsm_bts_trx *trx;
 
 	switch (event) {
 	case NM_EV_SW_ACT:
 		oml_mo_tx_sw_act_rep(&bts->mo);
+
+		llist_for_each_entry(trx, &bts->trx_list, list) {
+			/* During startup, phy_links are already opened, but if we are
+			 * re-connecting, phy_link was closed when disconnected from
+			 * previous BSC, so let's re-open it.
+			 */
+			struct phy_instance *pinst = trx_phy_instance(trx);
+			struct phy_link *plink = pinst->phy_link;
+			if (phy_link_state_get(plink) == PHY_LINK_SHUTDOWN)
+				bts_model_phy_link_open(plink);
+		}
+
 		nm_bts_fsm_state_chg(fi, NM_BTS_ST_OP_DISABLED_OFFLINE);
 		return;
 	default:

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25530
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ia1df6f4a1e0e6daeffe7303d518776a04b023930
Gerrit-Change-Number: 25530
Gerrit-PatchSet: 6
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210923/a4ccd5a3/attachment.htm>