Change in osmo-bts[master]: l1sap: Support rx of empty rlcmac blocks from PCU

[pespin]

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25534 )

Change subject: l1sap: Support rx of empty rlcmac blocks from PCU
......................................................................

l1sap: Support rx of empty rlcmac blocks from PCU

This way the PCU can signal idle RLCMAC blocks (no transmission
required) to the BTS, which can then send dummy/fill blocks aplying
power reduction as needed by TRX.

The block with len=0 is submitted to lower layers up to the scheduler,
which will finally drop it in trx_sched_ph_data_req().

Change-Id: I734c66e236bf3e2015a4571ea1fd84849a9ef02c
Related: SYS#4919
---
M src/common/l1sap.c
1 file changed, 6 insertions(+), 2 deletions(-)

Approvals:
  fixeria: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  osmith: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index 8aa80e7..b9bc675 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -1977,8 +1977,12 @@
 	l1sap->u.data.chan_nr = RSL_CHAN_OSMO_PDCH | ts->nr;
 	l1sap->u.data.link_id = 0x00;
 	l1sap->u.data.fn = fn;
-	msg->l2h = msgb_put(msg, len);
-	memcpy(msg->l2h, data, len);
+	if (len) {
+		msg->l2h = msgb_put(msg, len);
+		memcpy(msg->l2h, data, len);
+	} else {
+		msg->l2h = NULL; /* Idle block */
+	}
 
 	return l1sap_down(ts->trx, l1sap);
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25534
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I734c66e236bf3e2015a4571ea1fd84849a9ef02c
Gerrit-Change-Number: 25534
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210923/1b20c552/attachment.htm>