This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25288 ) Change subject: rsl: simplfy parse_repeated_acch_capability ...................................................................... rsl: simplfy parse_repeated_acch_capability The separate TLVP_PRESENT and TLVP_LEN calls can be replaced by a single TLVP_PRES_LEN Change-Id: I6bde1b9df50fdf355e768f5066e86422238b98e9 --- M src/common/rsl.c 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/common/rsl.c b/src/common/rsl.c index ca40e49..368590c 100644 --- a/src/common/rsl.c +++ b/src/common/rsl.c @@ -1589,9 +1589,7 @@ memset(&lchan->repeated_acch_capability, 0, sizeof(lchan->repeated_acch_capability)); - if (!TLVP_PRESENT(tp, RSL_IE_OSMO_REP_ACCH_CAP)) - return; - if (TLVP_LEN(tp, RSL_IE_OSMO_REP_ACCH_CAP) != sizeof(lchan->repeated_acch_capability)) + if (!TLVP_PRES_LEN(tp, RSL_IE_OSMO_REP_ACCH_CAP, sizeof(lchan->repeated_acch_capability))) return; memcpy(&lchan->repeated_acch_capability, TLVP_VAL(tp, RSL_IE_OSMO_REP_ACCH_CAP), -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25288 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6bde1b9df50fdf355e768f5066e86422238b98e9 Gerrit-Change-Number: 25288 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210923/8f3323f8/attachment.htm>