Change in osmo-ttcn3-hacks[master]: pcu: Adapt tests to pass with new idle blocks from PCU

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Wed Sep 22 18:09:49 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25537 )

Change subject: pcu: Adapt tests to pass with new idle blocks from PCU
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25537/1/pcu/PCU_Tests.ttcn 
File pcu/PCU_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25537/1/pcu/PCU_Tests.ttcn@595 
PS1, Line 595: empty blocks
Well, the idea of this test case was to check if the IUT generates _valid_ PTCCH/D messages. Not just empty blocks. And now we're unable to test that. What if we make it configurable via the INFO.ind? New osmo-bts versions (and some test cases) will indicate that they do support empty DATA.req messages, while old versions would not and thus receive all blocks.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25537/1/pcu/PCU_Tests.ttcn@5998 
PS1, Line 5998: idle
empty



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25537
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6e96a7569640695ccfaa94b471384fa301bccd62
Gerrit-Change-Number: 25537
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Wed, 22 Sep 2021 18:09:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210922/4972ff60/attachment.htm>


More information about the gerrit-log mailing list