Change in osmo-pcu[master]: tbf_ul_ass_fsm.c: Fix missing state transition in FSM description

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Wed Sep 22 14:55:41 UTC 2021


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25540 )


Change subject: tbf_ul_ass_fsm.c: Fix missing state transition in FSM description
......................................................................

tbf_ul_ass_fsm.c: Fix missing state transition in FSM description

As seen operating PCU after BTS restart, lots of following message
sequences due to FSM kept in same state (hence scheduler retyring every
time):
"""
DTBF tbf_ul_ass_fsm.c:306 UL_ASS_TBF(DL-TFI_0){SEND_ASS}: Received Event CREATE_RLCMAC_MSG
DTBF tbf_ul_ass_fsm.c:95 TBF(TFI=0 TLLI=0xf80bd801 DIR=DL STATE=RELEASING EGPRS) We have a schedule for uplink assignment, but there is no uplink TBF
DTBF tbf_ul_ass_fsm.c:97 UL_ASS_TBF(DL-TFI_0){SEND_ASS}: transition to state NONE not permitted!
DTBF tbf_ul_ass_fsm.c:306 UL_ASS_TBF(DL-TFI_0){SEND_ASS}: Received Event CREATE_RLCMAC_MSG
"""

Change-Id: I91d74f70a9106ccbf0c137b6e713877f9ea8f59d
---
M src/tbf_ul_ass_fsm.c
1 file changed, 3 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/40/25540/1

diff --git a/src/tbf_ul_ass_fsm.c b/src/tbf_ul_ass_fsm.c
index eab34ee..618e072 100644
--- a/src/tbf_ul_ass_fsm.c
+++ b/src/tbf_ul_ass_fsm.c
@@ -257,7 +257,9 @@
 	},
 	[TBF_UL_ASS_SEND_ASS] = {
 		.in_event_mask = X(TBF_UL_ASS_EV_CREATE_RLCMAC_MSG),
-		.out_state_mask = X(TBF_UL_ASS_WAIT_ACK),
+		.out_state_mask =
+			X(TBF_UL_ASS_WAIT_ACK) |
+			X(TBF_UL_ASS_NONE),
 		.name = "SEND_ASS",
 		.action = st_send_ass,
 	},

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25540
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I91d74f70a9106ccbf0c137b6e713877f9ea8f59d
Gerrit-Change-Number: 25540
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210922/cb0476a1/attachment.htm>


More information about the gerrit-log mailing list