This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://email@example.com/.neels gerrit-no-reply at lists.osmocom.org
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/25233 ) Change subject: gen_makefile.py: drop argument for deps file ...................................................................... Patch Set 2: (4 comments) posted my nitpicks but you can also just fix the typo and merge it. don't spend too much time on it. https://gerrit.osmocom.org/c/osmo-dev/+/25233/2/README File README: https://gerrit.osmocom.org/c/osmo-dev/+/25233/2/README@43 PS2, Line 43: Run ./gen_makefile.py with a choice of choice of configure options. meta choice https://gerrit.osmocom.org/c/osmo-dev/+/25233/2/gen_makefile.py File gen_makefile.py: https://gerrit.osmocom.org/c/osmo-dev/+/25233/2/gen_makefile.py@248 PS2, Line 248: continue i kind of like to keep that explicit .deps argument; now you did all the work to remove it. "explicit is better than implicit" well it doesn't really matter either way, will have zero impact on my daily work. it's just a personal preference of mine to allow a .deps file arg https://gerrit.osmocom.org/c/osmo-dev/+/25233/2/gen_makefile.py@255 PS2, Line 255: make_dir = 'make-3G+2G-%s' % opts_names let's just drop '-3G+2G'? https://gerrit.osmocom.org/c/osmo-dev/+/25233/2/gen_makefile.py@277 PS2, Line 277: default: usrp Maybe as default just print a listing of existing meaningful targets? because if you like usrp and i like cn, we can't agree. that was the advantage of the custom .deps file, 'make all' would build your choice. we could pass a favorite default target to gen_makefile.py but IMO not worth the trouble -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/25233 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I6394882f67eecda3d2c03a97d3119657f7d3873f Gerrit-Change-Number: 25233 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith at sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Comment-Date: Tue, 21 Sep 2021 10:28:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210921/04b790b6/attachment.htm>