Change in osmo-bts[master]: abis: Move FSM registration to constructor function

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Sep 20 12:19:00 UTC 2021


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25511 )

Change subject: abis: Move FSM registration to constructor function
......................................................................

abis: Move FSM registration to constructor function

We commonly do it this way since there's only need to call it once at
the startup of the program.

Change-Id: I6ee5b89175ee32bc12a8afc9682a8f90d1713291
---
M src/common/abis.c
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  fixeria: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/common/abis.c b/src/common/abis.c
index e82ac96..9b0a5b3 100644
--- a/src/common/abis.c
+++ b/src/common/abis.c
@@ -446,7 +446,6 @@
 		return -EINVAL;
 	}
 
-	OSMO_ASSERT(osmo_fsm_register(&abis_link_fsm) == 0);
 	bts->abis_link_fi = osmo_fsm_inst_alloc(&abis_link_fsm, bts, NULL, LOGL_DEBUG, "abis_link");
 	OSMO_ASSERT(bts->abis_link_fi);
 
@@ -461,3 +460,8 @@
 
 	return 0;
 }
+
+static __attribute__((constructor)) void abis_link_fsm_init(void)
+{
+	OSMO_ASSERT(osmo_fsm_register(&abis_link_fsm) == 0);
+}

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25511
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I6ee5b89175ee32bc12a8afc9682a8f90d1713291
Gerrit-Change-Number: 25511
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210920/04a0c535/attachment.htm>


More information about the gerrit-log mailing list