Change in osmo-bts[master]: abis.c: Transition to CONNECTED state only when OML link is up

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Sep 20 12:18:25 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25457 )

Change subject: abis.c: Transition to CONNECTED state only when OML link is up
......................................................................


Patch Set 4: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/25457/3/src/common/abis.c 
File src/common/abis.c:

https://gerrit.osmocom.org/c/osmo-bts/+/25457/3/src/common/abis.c@105 
PS3, Line 105: drain_oml_queue
> You could just add a forward declaration instead of moving this function around.
I prefer having function helpers above in the file, then all FSM functions below.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25457
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I43e83b1b04fbaa1f87818c096e6ad3920801b1f6
Gerrit-Change-Number: 25457
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 20 Sep 2021 12:18:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210920/3fdbc45d/attachment.htm>


More information about the gerrit-log mailing list