Change in pysim[master]: pySim-prog: rename card_handler to CardHandler

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Fri Sep 17 15:20:31 UTC 2021


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/25499 )

Change subject: pySim-prog: rename card_handler to CardHandler
......................................................................


Patch Set 5: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/pysim/+/25499/5/pySim-prog.py 
File pySim-prog.py:

https://gerrit.osmocom.org/c/pysim/+/25499/5/pySim-prog.py@203 
PS5, Line 203: 	parser.add_option("--card_handler", dest="card_handler", metavar="FILE",
I'm not familiar at all with the pySim codebase. But FWIW, I would find it much more readable if the option here has dest="card_handler_config". Maybe make that as additional patch?



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/25499
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I4b2c06b1c607c993c9aaf0d57ad2352bb6b36e74
Gerrit-Change-Number: 25499
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 17 Sep 2021 15:20:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210917/ac856ab0/attachment.htm>


More information about the gerrit-log mailing list