Change in osmo-pcu[master]: Add stats: pcu.bts.N.pdch.occupied.gprs/egprs

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25400 )

Change subject: Add stats: pcu.bts.N.pdch.occupied.gprs/egprs
......................................................................


Patch Set 3:

(5 comments)

https://gerrit.osmocom.org/c/osmo-pcu/+/25400/3/src/pdch.cpp 
File src/pdch.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/25400/3/src/pdch.cpp@1041 
PS3, Line 1041: 	enum tbf_type type = tbf->is_egprs_enabled() ? TBF_TYPE_EGPRS : TBF_TYPE_GPRS;
> you can simply change this to: […]
I split it into two variables, as suggested in your other comment.


https://gerrit.osmocom.org/c/osmo-pcu/+/25400/3/src/pdch.cpp@1073 
PS3, Line 1073: 	num_tbfs_update(tbf, 1);
> it's a bool, then true/false.
Done


https://gerrit.osmocom.org/c/osmo-pcu/+/25400/3/src/pdch.cpp@1093 
PS3, Line 1093: 	num_tbfs_update(tbf, 0);
> it's a bool, then true/false.
Done


https://gerrit.osmocom.org/c/osmo-pcu/+/25400/3/src/tbf.h 
File src/tbf.h:

https://gerrit.osmocom.org/c/osmo-pcu/+/25400/3/src/tbf.h@89 
PS3, Line 89: enum tbf_type {
> I would really avoid having an enum for 2 different options, which can be easily simplified to "is_e […]
Done


https://gerrit.osmocom.org/c/osmo-pcu/+/25400/2/src/tbf.cpp 
File src/tbf.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/25400/2/src/tbf.cpp@779 
PS2, Line 779: 		if (direction == GPRS_RLCMAC_DL_TBF && pdch[ts]->dl_tbf_by_tfi(m_tfi) != this)
> IIRC pdch is an array of pointers to pdch structs, which are non null only on TS where the TBF is at […]
Oh you're right! then it's not needed, removed.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25400
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I0c0a1121b4ae5f031782e7e63a0c28eb0b6c8b42
Gerrit-Change-Number: 25400
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 17 Sep 2021 11:15:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210917/d450e8ac/attachment.htm>