Change in pysim[master]: pySim-prog: rename card_handler to Card_handler

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Fri Sep 17 10:37:18 UTC 2021


dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/25499 )


Change subject: pySim-prog: rename card_handler to Card_handler
......................................................................

pySim-prog: rename card_handler to Card_handler

In OOP, we usually use capital letters for class names. The card handler
class should be no execption.

Change-Id: I4b2c06b1c607c993c9aaf0d57ad2352bb6b36e74
---
M pySim-prog.py
M pySim/card_handler.py
2 files changed, 4 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/99/25499/1

diff --git a/pySim-prog.py b/pySim-prog.py
index 4c85be7..849e703 100755
--- a/pySim-prog.py
+++ b/pySim-prog.py
@@ -741,9 +741,9 @@
 	init_batch(opts)
 
 	if opts.card_handler:
-		card_handler = card_handler_auto(sl, opts.card_handler)
+		card_handler = Card_handler_auto(sl, opts.card_handler)
 	else:
-		card_handler = card_handler(sl)
+		card_handler = Card_handler(sl)
 
 	# Iterate
 	first = True
diff --git a/pySim/card_handler.py b/pySim/card_handler.py
index 9beab51..bce0416 100644
--- a/pySim/card_handler.py
+++ b/pySim/card_handler.py
@@ -27,7 +27,7 @@
 import yaml
 
 # Manual card handler: User is prompted to insert/remove card from the reader.
-class card_handler:
+class Card_handler:
 
 	sl = None
 
@@ -47,7 +47,7 @@
 		print("")
 
 # Automatic card handler: A machine is used to handle the cards.
-class card_handler_auto:
+class Card_handler_auto:
 
 	sl = None
 	cmds = None

-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/25499
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I4b2c06b1c607c993c9aaf0d57ad2352bb6b36e74
Gerrit-Change-Number: 25499
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210917/3fe1c96b/attachment.htm>


More information about the gerrit-log mailing list