This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25401 )
Change subject: pdch: has_gprs_only_tb_attached: use m_num_tbfs
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/c/osmo-pcu/+/25401/2/src/pdch.cpp
File src/pdch.cpp:
https://gerrit.osmocom.org/c/osmo-pcu/+/25401/2/src/pdch.cpp@1112
PS2, Line 1112: return (m_num_tbfs[GPRS_RLCMAC_UL_TBF][TBF_TYPE_GPRS] + m_num_tbfs[GPRS_RLCMAC_DL_TBF][TBF_TYPE_GPRS]) > 0;
I'd welcome split in 2 lines, will look easier to understand since both lines are almost the same:
return (m_num_tbfs[GPRS_RLCMAC_UL_TBF][TBF_TYPE_GPRS] +
m_num_tbfs[GPRS_RLCMAC_DL_TBF][TBF_TYPE_GPRS]) > 0;
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25401
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I1dd7df2c740ea604f07c65bebcb7c0051aebf9ae
Gerrit-Change-Number: 25401
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 16 Sep 2021 19:11:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210916/92deaa96/attachment.htm>