Change in osmo-pcu[master]: Add stats: pcu.bts.N.pdch.occupied.gprs/egprs

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25400 )

Change subject: Add stats: pcu.bts.N.pdch.occupied.gprs/egprs
......................................................................


Patch Set 2: Code-Review-1

(5 comments)

https://gerrit.osmocom.org/c/osmo-pcu/+/25400/2/src/pdch.h 
File src/pdch.h:

https://gerrit.osmocom.org/c/osmo-pcu/+/25400/2/src/pdch.h@81 
PS2, Line 81: 	void num_tbfs_update(gprs_rlcmac_tbf *tbf, enum tbf_type type, bool is_attach);
type should be known from tbf, no need to pass it?


https://gerrit.osmocom.org/c/osmo-pcu/+/25400/2/src/pdch.cpp 
File src/pdch.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/25400/2/src/pdch.cpp@1065 
PS2, Line 1065: 	enum tbf_type type = tbf->is_egprs_enabled() ? TBF_TYPE_EGPRS : TBF_TYPE_GPRS;
why aren't you calling tbf->is_egprs_enabled() inside num_tbfs_update()!?


https://gerrit.osmocom.org/c/osmo-pcu/+/25400/2/src/tbf.h 
File src/tbf.h:

https://gerrit.osmocom.org/c/osmo-pcu/+/25400/2/src/tbf.h@90 
PS2, Line 90: 	TBF_TYPE_GPRS,
No need for this!


https://gerrit.osmocom.org/c/osmo-pcu/+/25400/2/src/tbf.cpp 
File src/tbf.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/25400/2/src/tbf.cpp@773 
PS2, Line 773: 	for (int ts = 0; ts < 8; ts++) {
what about using ARRAY_SIZE(pdch) here instead of 8?


https://gerrit.osmocom.org/c/osmo-pcu/+/25400/2/src/tbf.cpp@779 
PS2, Line 779: 		if (direction == GPRS_RLCMAC_DL_TBF && pdch[ts]->dl_tbf_by_tfi(m_tfi) != this)
why are the last 2 if conditions needed? if pdch[ts] it means it's attached right? no need to do this second check you do here.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25400
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I0c0a1121b4ae5f031782e7e63a0c28eb0b6c8b42
Gerrit-Change-Number: 25400
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 16 Sep 2021 19:10:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210916/f98ac201/attachment.htm>