Change in osmo-bts[master]: abis.c: Fix mess with priv->bsc_oml_host

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Sep 16 11:06:45 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25458 )

Change subject: abis.c: Fix mess with priv->bsc_oml_host
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/25458/2/include/osmo-bts/abis.h 
File include/osmo-bts/abis.h:

https://gerrit.osmocom.org/c/osmo-bts/+/25458/2/include/osmo-bts/abis.h@12 
PS2, Line 12: 	ABIS_LINK_EV_VTY_RM_ADDR, /* data: struct bsc_oml_host* being removed */
> Is this a leftover or intentional?
Intentional, I'm documenting the same structure I'm changing in the FSM implementation. It was one of the points being a mess. VTY code was calling this event already passing struct bsc_oml_host, but in the FSM it was being matches directly against the llist_head. It just worked because the llist_head was the first item of the struct.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25458
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I3cc8a4148b3d63bc185b72dab8108105a6644910
Gerrit-Change-Number: 25458
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Thu, 16 Sep 2021 11:06:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210916/43e4e788/attachment.htm>


More information about the gerrit-log mailing list