Change in libosmocore[master]: stat_item: add osmo_stat_item_get()

[neels]

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25463 )

Change subject: stat_item: add osmo_stat_item_get()
......................................................................


Patch Set 1:

> Not sure we really need this API

Actually you're right. This came up while hacking on stats_test.c, while most real world callers actually have a osmo_stat_item_group pointer at hand already, e.g.

osmo-bsc/src/osmo-bsc/bts.c:817:	osmo_stat_item_set(osmo_stat_item_group_get_item(bts->bts_statg, BTS_STAT_CHAN_OSMO_DYN_TOTAL), 0);

This here is an example of the actual use I was aiming to make nicer.
Would you agree that it would look better as:

 osmo_stat_item_set2(bts->bts_statg, BTS_STAT_CHAN_OSMO_DYN_TOTAL, 0);

?

OT now, but your con mentioning optimization is not valid IMO, because it is speculating on callers and is only about an O(n) algorithm. Your con about no-one besides stats_test.c using this function is indeed valid. I think I might put it static in stats_test.c or not bother at all.


-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25463
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I58886ae8af6b1f770088410f63d27ac21bf979fb
Gerrit-Change-Number: 25463
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 15 Sep 2021 17:56:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210915/9af543f5/attachment.htm>