This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25335 ) Change subject: mgcp_client: add MGW name as logging context ...................................................................... Patch Set 4: (3 comments) thanks for reviewing this. https://gerrit.osmocom.org/c/osmo-mgw/+/25335/4//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-mgw/+/25335/4//COMMIT_MSG@18 PS4, Line 18: and mgcp_client_pool.c > (Two logical changes in one commit, reviewing would have been easier if they were separate. […] I think it is better to have both in one commit. The naming feature is introduced and then used. Introducing it without using it then would also not have been optimal. https://gerrit.osmocom.org/c/osmo-mgw/+/25335/4/src/libosmo-mgcp-client/mgcp_client.c File src/libosmo-mgcp-client/mgcp_client.c: https://gerrit.osmocom.org/c/osmo-mgw/+/25335/4/src/libosmo-mgcp-client/mgcp_client.c@1513 PS4, Line 1513: mame > name Done https://gerrit.osmocom.org/c/osmo-mgw/+/25335/4/src/libosmo-mgcp-client/mgcp_client_pool.c File src/libosmo-mgcp-client/mgcp_client_pool.c: https://gerrit.osmocom.org/c/osmo-mgw/+/25335/4/src/libosmo-mgcp-client/mgcp_client_pool.c@54 PS4, Line 54: snprintf(name, sizeof(name), "%d:%s", pool_member->nr, description); > the code to obtain description seems to be duplicated in mgcp_client_name(). […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25335 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I53ff5445c8e5faffa4ef908ffb1fdb1f47ea2904 Gerrit-Change-Number: 25335 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-CC: osmith <osmith at sysmocom.de> Gerrit-Comment-Date: Mon, 13 Sep 2021 14:02:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210913/2a9921f8/attachment.htm>