This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25429 ) Change subject: rename strip_epname and find_specific_endpoint and make them available ...................................................................... Patch Set 12: (2 comments) looks good to me, but it would need some polishing. https://gerrit.osmocom.org/c/osmo-mgw/+/25429/12/src/libosmo-mgcp/mgcp_endp.c File src/libosmo-mgcp/mgcp_endp.c: https://gerrit.osmocom.org/c/osmo-mgw/+/25429/12/src/libosmo-mgcp/mgcp_endp.c@194 PS12, Line 194: * (epname) */ this is now public, so the comment above should be converted into doxygen. I would name it mgcp_strip_epname, this is shorter and makes more clear that the function does something with the name only and not with the "endp", which is used differently. https://gerrit.osmocom.org/c/osmo-mgw/+/25429/12/src/libosmo-mgcp/mgcp_endp.c@223 PS12, Line 223: * return NULL */ Also needs doxygen comments. (Here "endp" is used correctly) -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25429 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I4f76676640a308ab84da3848e1c1ec22bd5d9566 Gerrit-Change-Number: 25429 Gerrit-PatchSet: 12 Gerrit-Owner: Hoernchen <ewild at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-CC: dexter <pmaier at sysmocom.de> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 13 Sep 2021 12:24:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210913/400c6618/attachment.htm>