This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25425 ) Change subject: e1: one thread per e1 trunk == e1 line ...................................................................... Patch Set 10: Code-Review-1 (2 comments) I fear there is a problem with this. This this_trunk variable will limit us to use only one E1 trunk in osmo-mgw but when I get it right we already support multiple E1 trunks. One E1 line can have (NUM_E1_TS-1) usable timeslots. That is one physical line on the E1 card. If you have multiple physical lines, each one will get its own trunk. https://gerrit.osmocom.org/c/osmo-mgw/+/25425/10/src/libosmo-mgcp/mgcp_e1.c File src/libosmo-mgcp/mgcp_e1.c: https://gerrit.osmocom.org/c/osmo-mgw/+/25425/10/src/libosmo-mgcp/mgcp_e1.c@a337 PS10, Line 337: /* Find associated trunk */ (see also below) I think your change will limit us to to one E1 line. https://gerrit.osmocom.org/c/osmo-mgw/+/25425/10/src/libosmo-mgcp/mgcp_e1.c@372 PS10, Line 372: this_trunk = trunk; I wonder if this is really equivalent. Please check this again. I don't think that I have implemented this so that only one E1 line can be used. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25425 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Iabee6375dc521397d605549e3d869d5c8048fac3 Gerrit-Change-Number: 25425 Gerrit-PatchSet: 10 Gerrit-Owner: Hoernchen <ewild at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 13 Sep 2021 12:19:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210913/abdd0758/attachment.htm>