This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25431 ) Change subject: add a lock-free bounded spsc interthread queue ...................................................................... Patch Set 14: (3 comments) https://gerrit.osmocom.org/c/osmo-mgw/+/25431/14/include/osmocom/mgcp/mgcp_threads_queue.h File include/osmocom/mgcp/mgcp_threads_queue.h: https://gerrit.osmocom.org/c/osmo-mgw/+/25431/14/include/osmocom/mgcp/mgcp_threads_queue.h@25 PS14, Line 25: maybe dropping a comment about spsc = single producer single consumer would be helpful. Maybe it makes sense to replace the "spsc" in the function names with something that explains the purpose of the queue better. https://gerrit.osmocom.org/c/osmo-mgw/+/25431/14/include/osmocom/mgcp/mgcp_threads_queue.h@43 PS14, Line 43: The public parts of the API would get an mgcp_ in front of. Like mgcp_spsc_push() https://gerrit.osmocom.org/c/osmo-mgw/+/25431/14/src/libosmo-mgcp/mgcp_threads_queue.c File src/libosmo-mgcp/mgcp_threads_queue.c: https://gerrit.osmocom.org/c/osmo-mgw/+/25431/14/src/libosmo-mgcp/mgcp_threads_queue.c@134 PS14, Line 134: wrfd used interally to block writers coding style: we use doxygen here (see other c files) -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25431 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I4f17042baf76d086ce6b20eb99402dc64c22c657 Gerrit-Change-Number: 25431 Gerrit-PatchSet: 14 Gerrit-Owner: Hoernchen <ewild at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: dexter <pmaier at sysmocom.de> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 13 Sep 2021 12:01:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210913/be4b841b/attachment.htm>