Change in osmo-bts[master]: TA loop: Take into account UL SACCH 'Actual Timing advance' field

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Sep 13 10:56:31 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25386 )

Change subject: TA loop: Take into account UL SACCH 'Actual Timing advance' field
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/25386/2/src/common/ta_control.c 
File src/common/ta_control.c:

https://gerrit.osmocom.org/c/osmo-bts/+/25386/2/src/common/ta_control.c@54 
PS2, Line 54: toa256 - (256 * delta_ta))
> so with delta_ta = toa256/256, this is: […]
You are forgetting rounding here due to integer div. That's precisely what I'm seeking here: check whether we also exceeded TOA256_9OPERCENT towards next TA val.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25386
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I2d0f128c8dcac93ee382283a1c91fca76623b8fc
Gerrit-Change-Number: 25386
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Mon, 13 Sep 2021 10:56:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210913/756a94c5/attachment.htm>


More information about the gerrit-log mailing list