Change in osmo-pcu[master]: Support Neighbor Address Resolution over PCUIF IPA multiplex

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Mon Sep 13 10:00:47 UTC 2021


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25404 )

Change subject: Support Neighbor Address Resolution over PCUIF IPA multiplex
......................................................................


Patch Set 3:

(8 comments)

Code looks good!

https://gerrit.osmocom.org/c/osmo-pcu/+/25404/3//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-pcu/+/25404/3//COMMIT_MSG@9 
PS3, Line 9: initiall
initially


https://gerrit.osmocom.org/c/osmo-pcu/+/25404/3//COMMIT_MSG@23 
PS3, Line 23: ANR
maybe NAR for Neighbor Address Resolution?


https://gerrit.osmocom.org/c/osmo-pcu/+/25404/3//COMMIT_MSG@32 
PS3, Line 32: rbeaking
breaking


https://gerrit.osmocom.org/c/osmo-pcu/+/25404/3//COMMIT_MSG@35 
PS3, Line 35: TODO: value inside container must be encoded in network order!!!
unresolved TODO inside the commit message?


https://gerrit.osmocom.org/c/osmo-pcu/+/25404/3/doc/manuals/chapters/configuration.adoc 
File doc/manuals/chapters/configuration.adoc:

https://gerrit.osmocom.org/c/osmo-pcu/+/25404/3/doc/manuals/chapters/configuration.adoc@255 
PS3, Line 255: nowwadays
nowadays


https://gerrit.osmocom.org/c/osmo-pcu/+/25404/3/doc/manuals/chapters/configuration.adoc@256 
PS3, Line 256:  
,


https://gerrit.osmocom.org/c/osmo-pcu/+/25404/3/doc/manuals/chapters/configuration.adoc@263 
PS3, Line 263: result, optimizing the resolution time too.
How about:

> These neighbor address resolutions (<ARFCN + BSIC> => <RAI + CI>) are by default
> cached for a while, in order to avoid querying the BSC frequently. As a result,
> the resolution time is also optimized.


https://gerrit.osmocom.org/c/osmo-pcu/+/25404/3/src/nacc_fsm.c 
File src/nacc_fsm.c:

https://gerrit.osmocom.org/c/osmo-pcu/+/25404/3/src/nacc_fsm.c@416 
PS3, Line 416: confiured tu se
configured to use



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25404
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I6ad33c7ab10202840cf804dea9ba595978d0e920
Gerrit-Change-Number: 25404
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Mon, 13 Sep 2021 10:00:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210913/bda0b19a/attachment.htm>


More information about the gerrit-log mailing list