Change in osmo-mgw[master]: rename do_retransmission

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sat Sep 11 12:59:53 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25419 )

Change subject: rename do_retransmission
......................................................................

rename do_retransmission

...because it does not "do"

Change-Id: I5513e0ad15db4a0629f4e0348fc3e84d9972259a
---
M src/libosmo-mgcp/mgcp_protocol.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve



diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c
index 88f1bd0..ba80d7d 100644
--- a/src/libosmo-mgcp/mgcp_protocol.c
+++ b/src/libosmo-mgcp/mgcp_protocol.c
@@ -183,7 +183,7 @@
 }
 
 /* Helper function for do_retransmission() and create_resp() */
-static struct msgb *do_retransmission(const struct mgcp_endpoint *endp)
+static struct msgb *create_retransmission_response(const struct mgcp_endpoint *endp)
 {
 	struct msgb *msg = mgcp_msgb_alloc();
 	if (!msg)
@@ -414,7 +414,7 @@
 		/* Check if we have to retransmit a response from a previous transaction */
 		if (pdata.trans && rq.endp->last_trans && strcmp(rq.endp->last_trans, pdata.trans) == 0) {
 			rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_GENERAL_RX_MSGS_RETRANSMITTED));
-			return do_retransmission(rq.endp);
+			return create_retransmission_response(rq.endp);
 		}
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25419
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I5513e0ad15db4a0629f4e0348fc3e84d9972259a
Gerrit-Change-Number: 25419
Gerrit-PatchSet: 5
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210911/1444cc9e/attachment.htm>


More information about the gerrit-log mailing list