Change in libosmocore[master]: vty sched: add api to force deferred applying

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri Sep 10 18:21:18 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25415 )

Change subject: vty sched: add api to force deferred applying
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/25415/2/src/vty/cpu_sched_vty.c 
File src/vty/cpu_sched_vty.c:

https://gerrit.osmocom.org/c/libosmocore/+/25415/2/src/vty/cpu_sched_vty.c@425 
PS2, Line 425: 	if (applynow) {
Let me clarify some bits about VTY semantics:

> So the problem imho is that your are interactively using a set of VTY commands in the "configure terminal" section which was aimed at be applied/parsed from config file during startup [...].

There is no such thing.  The "configure" node commands may be used at start-up, but they may also be used later at runtime.  We cannot make assumptions about when a user uses them.  They use them as they please. All we allow ourselves to do is to apply some changes immediately, and others only at whatever other natural point in time (bts resconnect, etc.), and we document that via attributes.

> 1- Have a new VTY command in the "enable" node which is aimed at interactively (while the program is running) setting/changing the cu affinity of a given (or all) thread. This new command would basically reuse most of the existing code in this function (cfg_sched_cpu_affinity_cmd) with the exception that it wouldn't store config (see line 451), or it would store it temporarily but not written back to cfg file (have a ->temporary=true).

"enable" style commands don't change persistent configuration.  That's what the configure node and its sub-nodes are for.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25415
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Id8405099e6b316c2e14fb0c9b3c5e80a68a91277
Gerrit-Change-Number: 25415
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 10 Sep 2021 18:21:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210910/22f389c7/attachment.htm>


More information about the gerrit-log mailing list