Change in osmo-mgw[master]: embed strings into structs

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25426 )

Change subject: embed strings into structs
......................................................................


Patch Set 9:

(10 comments)

strlen party!!!! Let's rename MGW to SCW: String Counting Gateway

https://gerrit.osmocom.org/c/osmo-mgw/+/25426/9/include/osmocom/mgcp/mgcp.h 
File include/osmocom/mgcp/mgcp.h:

https://gerrit.osmocom.org/c/osmo-mgw/+/25426/9/include/osmocom/mgcp/mgcp.h@97 
PS9, Line 97: 	/* addr or NULL to fall-back to default */
"addr or empty"


https://gerrit.osmocom.org/c/osmo-mgw/+/25426/9/src/libosmo-mgcp/mgcp_network.c 
File src/libosmo-mgcp/mgcp_network.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/25426/9/src/libosmo-mgcp/mgcp_network.c@138 
PS9, Line 138: 		if (!strlen(bind_addr))
bind_addr[0] == '\0'


https://gerrit.osmocom.org/c/osmo-mgw/+/25426/9/src/libosmo-mgcp/mgcp_network.c@141 
PS9, Line 141: 	if (strlen(bind_addr)) {
bind_addr[0] != '\0'


https://gerrit.osmocom.org/c/osmo-mgw/+/25426/9/src/libosmo-mgcp/mgcp_protocol.c 
File src/libosmo-mgcp/mgcp_protocol.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/25426/9/src/libosmo-mgcp/mgcp_protocol.c@276 
PS9, Line 276: 	const char *addr = strlen(endp->cfg->local_ip) ? endp->cfg->local_ip : conn->end.local_addr;
endp->cfg->local_ip[0] != '\0'

We have better stuff to do than counting lengths of strings everywhere for no good use.


https://gerrit.osmocom.org/c/osmo-mgw/+/25426/9/src/libosmo-mgcp/mgcp_vty.c 
File src/libosmo-mgcp/mgcp_vty.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/25426/9/src/libosmo-mgcp/mgcp_vty.c@68 
PS9, Line 68: 	if (strlen(g_cfg->local_ip))
[0] != '\0'


https://gerrit.osmocom.org/c/osmo-mgw/+/25426/9/src/libosmo-mgcp/mgcp_vty.c@75 
PS9, Line 75: 	if (strlen(g_cfg->net_ports.bind_addr_v4))
same


https://gerrit.osmocom.org/c/osmo-mgw/+/25426/9/src/libosmo-mgcp/mgcp_vty.c@78 
PS9, Line 78: 	if (strlen(g_cfg->net_ports.bind_addr_v6))
same


https://gerrit.osmocom.org/c/osmo-mgw/+/25426/9/src/libosmo-mgcp/mgcp_vty.c@1749 
PS9, Line 1749: 	if (!strlen(g_cfg->source_addr)) {
same


https://gerrit.osmocom.org/c/osmo-mgw/+/25426/9/src/osmo-mgw/mgw_main.c 
File src/osmo-mgw/mgw_main.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/25426/9/src/osmo-mgw/mgw_main.c@372 
PS9, Line 372: 	if (strlen(cfg->call_agent_addr))
same


https://gerrit.osmocom.org/c/osmo-mgw/+/25426/9/src/osmo-mgw/mgw_main.c@377 
PS9, Line 377: 				cfg->call_agent_addr, strlen(cfg->call_agent_addr) ? 2727 : 0, flags);
same



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25426
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I7b46d531c5d3b53984f2ce44538116973f6a074d
Gerrit-Change-Number: 25426
Gerrit-PatchSet: 9
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 10 Sep 2021 11:32:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210910/9e10c92f/attachment.htm>