Change in osmo-ttcn3-hacks[master]: ns: add tests to test UNITDATA over a BLOCKED nsvcs

[lynxis lazus]

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25352 )

Change subject: ns: add tests to test UNITDATA over a BLOCKED nsvcs
......................................................................

ns: add tests to test UNITDATA over a BLOCKED nsvcs

The UNITDATA should be rejected by a NS STATUS PDU.

Change-Id: I62ce93ca4953f8b0476a15479089db2f6c2fa684
---
M ns/NS_Tests.ttcn
1 file changed, 55 insertions(+), 2 deletions(-)

Approvals:
  lynxis lazus: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  osmith: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/ns/NS_Tests.ttcn b/ns/NS_Tests.ttcn
index 8553684..105d397 100644
--- a/ns/NS_Tests.ttcn
+++ b/ns/NS_Tests.ttcn
@@ -162,6 +162,52 @@
 	f_sleep(1.0);
 }
 
+/* 48.016 7.2.1 transmit a UNIT DATA over a BLOCKED NSVC when ttcn3 blocked it
+ *
+ * TTCN  -> NS: reset
+ * TTCN <-  NS: reset ack
+ * TTCN  -> NS: unblock
+ * TTCN <-  NS: unblock ack
+ * TTCN  -> NS: block
+ * TTCN <-  NS: block ack
+ * TTCN  -> NS: unitdata
+ * TTCN <-  NS: status (cause blocked)
+ */
+testcase TC_tx_block_unitdata_over_blocked() runs on RAW_Test_CT {
+	f_tx_block();
+	f_sleep(1.0);
+
+	NSCP[0].send(ts_NS_UNITDATA(t_SduCtrlB, 42, '0011234242230101'O));
+	f_ns_exp(tr_NS_STATUS(NS_CAUSE_NSVC_BLOCKED));
+
+	setverdict(pass);
+	f_sleep(1.0);
+	f_clean_ns_codec();
+}
+
+/* 48.016 7.2.1 transmit a UNIT DATA over a BLOCKED NSVC when ns2 blocked it
+ *
+ * TTCN  -> NS: reset
+ * TTCN <-  NS: reset ack
+ * TTCN  -> NS: unblock
+ * TTCN <-  NS: unblock ack
+ * TTCN <-  NS: block
+ * TTCN  -> NS: block ack
+ * TTCN  -> NS: unitdata
+ * TTCN <-  NS: status (cause blocked)
+ */
+testcase TC_rx_block_unitdata_over_blocked() runs on RAW_Test_CT {
+	tx_block_by_vty();
+	f_sleep(1.0);
+
+	NSCP[0].send(ts_NS_UNITDATA(t_SduCtrlB, 42, '0011234242230101'O));
+	f_ns_exp(tr_NS_STATUS(NS_CAUSE_NSVC_BLOCKED));
+
+	setverdict(pass);
+	f_sleep(1.0);
+	f_clean_ns_codec();
+}
+
 /* 48.016 7.2 unblock procedure
  *
  * TTCN  -> NS: reset
@@ -219,9 +265,9 @@
  * TTCN  -> NS: block
  * TTCN <-  NS: block ack
  */
-testcase TC_tx_block() runs on RAW_Test_CT {
+function f_tx_block(float guard_secs := 30.0) runs on RAW_Test_CT {
 	f_init_vty();
-	f_init_ns_codec(mp_nsconfig, guard_secs := 30.0);
+	f_init_ns_codec(mp_nsconfig, guard_secs := guard_secs);
 
 	/* do a NS Reset procedure */
 	f_outgoing_ns_reset();
@@ -235,6 +281,11 @@
 	f_sleep(1.0);
 }
 
+testcase TC_tx_block() runs on RAW_Test_CT {
+	f_tx_block()
+	f_clean_ns_codec();
+}
+
 /* 48.016 7.2 block procedure by vty
  *
  * TTCN  -> NS: reset
@@ -860,6 +911,8 @@
 		execute( TC_tx_block() );
 		execute( TC_tx_block_by_vty() );
 		execute( TC_tx_block_by_vty_reset() );
+		execute( TC_tx_block_unitdata_over_blocked() );
+		execute( TC_rx_block_unitdata_over_blocked() );
 		// execute( TC_block_other_nsvc() ); // reset, unblock, sleep(1), block over another nsvci
 		/* 48.016 7.2 Unblock procedure */
 		execute( TC_tx_unblock() );

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25352
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I62ce93ca4953f8b0476a15479089db2f6c2fa684
Gerrit-Change-Number: 25352
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210907/e6e069e4/attachment.htm>