This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25345 ) Change subject: utils: add osmo_str_to_int() and osmo_str_to_int64() ...................................................................... Patch Set 2: TBH I forgot to write about it, but I found it weird that you returned positive in that case. I'd prefer returning negative on all errors. After all, you can still check the exact error to decide what to do. IMHO it makes sense to return psoitive or negative if the "success" range is more than 1 value, for instance returning error or a size. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25345 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4dac826aab00bc1780a5258b6b55d34ce7d50c60 Gerrit-Change-Number: 25345 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 07 Sep 2021 12:36:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210907/f20dc7b2/attachment.htm>