This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
osmith gerrit-no-reply at lists.osmocom.orgosmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25341 ) Change subject: ns: add TC_sns_bss_remove_bind_fail_sns to check SNS fails correct when removing a bind ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25341/2/ns/NS_Tests.ttcn File ns/NS_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25341/2/ns/NS_Tests.ttcn@715 PS2, Line 715: /* 2nd bind won't have a valid connection to the ttcn3 */ the other test cases you've added in the patchset are easy to read. but this one is not so clear to me. How is it verified that "2nd bind won't have a valid connection to the ttcn3"? I'm guessing because there are only t_NS_ALIVE received and nothing else? It would be nice if the comment explained this a bit better. (but overall looking good and it seems you know what you are doing, so this doesn't need to block the merge.) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25341 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8f7daee7a3bcadf64e8ae607619425adbefe3c4b Gerrit-Change-Number: 25341 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 07 Sep 2021 09:54:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210907/9a8acc96/attachment.htm>