Change in osmo-ttcn3-hacks[master]: ns2: mark TC_sns_bss_all_signalling_nsvcs_failed as broken

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Sun Sep 5 19:45:19 UTC 2021


lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25141 )

Change subject: ns2: mark TC_sns_bss_all_signalling_nsvcs_failed as broken
......................................................................

ns2: mark TC_sns_bss_all_signalling_nsvcs_failed as broken

The test case tests the wrong side. The signalling
and data weight are valid for the other side. The correct
test case needs to add a second bind on the ttcn3 side because
the signalling and data weight is valid for the remote side.

Change-Id: Ice79a038b0b8df9e69232bb24b2f2b18b3632758
---
M ns/NS_Tests.ttcn
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved
  dexter: Looks good to me, but someone else must approve



diff --git a/ns/NS_Tests.ttcn b/ns/NS_Tests.ttcn
index 733bad1..e9c3bf4 100644
--- a/ns/NS_Tests.ttcn
+++ b/ns/NS_Tests.ttcn
@@ -654,6 +654,10 @@
  * 3. add second bind to SNS
  * 4. stop reacting to NS_ALIVE on first NSVC (only NSVC with sig weight)
  * 5. expect SNS SIZE
+ *
+ * Broken: the test case tests the wrong side. The signalling
+ * and data weight are valid for the other side. The correct
+ * test case needs to add a second bind on the ttcn3 side.
  */
 testcase TC_sns_bss_all_signalling_nsvcs_failed() runs on RAW_Test_CT {
 	g_handle_rx_alive := true;
@@ -779,7 +783,7 @@
 			execute( TC_sns_bss_add() );
 			execute( TC_sns_bss_del() );
 			execute( TC_sns_bss_add_change_del() );
-			execute( TC_sns_bss_all_signalling_nsvcs_failed() );
+			/* execute( TC_sns_bss_all_signalling_nsvcs_failed() ); */
 			execute( TC_sns_rx_size_force_unconf() );
 		}
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25141
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ice79a038b0b8df9e69232bb24b2f2b18b3632758
Gerrit-Change-Number: 25141
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210905/ee204491/attachment.htm>


More information about the gerrit-log mailing list