Change in libosmocore[master]: gsm_08_58.h: Extend IPA Power Control Params IEs to pass C/I params

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Fri Sep 3 16:01:03 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25299 )

Change subject: gsm_08_58.h: Extend IPA Power Control Params IEs to pass C/I params
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/25299/2/include/osmocom/gsm/protocol/gsm_08_58.h 
File include/osmocom/gsm/protocol/gsm_08_58.h:

https://gerrit.osmocom.org/c/libosmocore/+/25299/2/include/osmocom/gsm/protocol/gsm_08_58.h@929 
PS2, Line 929: uint8_t
> But 'ipac_preproc_pc_comp' is for RxLev and RxQual, which are unsigned. […]
These fields are independent of the value type of the measurement, it's just saying "p times out of N", so they unsigned since they are counters.

In any case, C/I thresholds are defined to be 0-30, hence unsigned, since other values are considered non interesting at all.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25299
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Iffef0611430ad6c90606149c398d80158633bbca
Gerrit-Change-Number: 25299
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 03 Sep 2021 16:01:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210903/3e391d39/attachment.htm>


More information about the gerrit-log mailing list