Change in osmo-bts[master]: BS Power Control Loop: Support EWMA average algo for RxQual meas

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Fri Sep 3 15:09:21 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25326 )

Change subject: BS Power Control Loop: Support EWMA average algo for RxQual meas
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/25326/3//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-bts/+/25326/3//COMMIT_MSG@9 
PS3, Line 9: the function lchan_bs_pwr_ctrl() code
I don't like that you mix up refactoring and enabling EWMA for RxQual in a single commit. I am also not sure if this refactoring really makes sense. I like it the way it's currently done, including the variable naming. Let's please submit both things separately.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25326
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: If7e3987df89d680cfa443195ab2f225681d0e6cf
Gerrit-Change-Number: 25326
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Fri, 03 Sep 2021 15:09:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210903/09ba8c6e/attachment.htm>


More information about the gerrit-log mailing list