This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25296 ) Change subject: sched_lchan_tch_x: use functions to determine AMR tranmssion phase ...................................................................... Patch Set 1: (2 comments) (not done yet, but I hope I could answer the question from laforge) https://gerrit.osmocom.org/c/osmo-bts/+/25296/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/25296/1//COMMIT_MSG@12 PS1, Line 12: receiver should use). codec idfentifer. The formulas in the present > 1-remove dot […] Done https://gerrit.osmocom.org/c/osmo-bts/+/25296/1/src/osmo-bts-trx/sched_lchan_tchf.c File src/osmo-bts-trx/sched_lchan_tchf.c: https://gerrit.osmocom.org/c/osmo-bts/+/25296/1/src/osmo-bts-trx/sched_lchan_tchf.c@470 PS1, Line 470: LOGL1SB(DL1P, LOGL_NOTICE, l1ts, br, "Codec (FT = %d) " > I don't understand this code in general, even the current one. […] The comment from laforge above also reflects my understanding. I think the problem that the code tries to solve is to sync the FT change on the transmission phase. Lets imagine the following situation: An RTP packet which has a different FT than the packet before arrives at the BTS. But at that moment the transmission phase is at CMR. In this situation we are unable to encode the AMR block for the radio interface because we have no way to encode the new FT into that block. All we can do is to encode a bad frame and go ahead. In the next round the transmission phase will be at FT and we can encode the new FT and everything is fine again. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25296 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I94a934a6b3b397b4cd0e9da3577325de58814335 Gerrit-Change-Number: 25296 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 01 Sep 2021 09:37:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge at osmocom.org> Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210901/d2de1844/attachment.htm>