Change in pysim[master]: pySim-shell: add method to probe for UICC

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26043 )

Change subject: pySim-shell: add method to probe for UICC
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/pysim/+/26043/1/pySim-shell.py 
File pySim-shell.py:

https://gerrit.osmocom.org/c/pysim/+/26043/1/pySim-shell.py@87 
PS1, Line 87: card_is_uicc = probe_card(card, ['UICC'])
why does the 'UICC' get passed in a list?

Also, why not simply have probe_card() return a list of card models/profiles?  This way  we would have something like:

probe_result = probe_card(card)
if 'SIM' in probe_result:
    ...
if 'USIM' in probe_result:
    ...


Furthermore, I think the entire 'card' model needs a more fundamental reform.  It made sense for pySim-prog supporting only a few very specific models of programmable cards.  But it makes no sense at all for pysim-shell.



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/26043
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I535bef35847140e611d4fa95ed2859ee81cce605
Gerrit-Change-Number: 26043
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Sun, 31 Oct 2021 07:27:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211031/2b1a4435/attachment.htm>