This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/25991 ) Change subject: hnbap: Use asn1c flag -fcompound-names to avoid name collisions with other libs ...................................................................... Patch Set 1: > Patch Set 1: > > > I'd rather have a bit longer names than really having to waste hours playing tetris with header files and source files. Having these patches solves the build problems in osmo-hnodeb and whoever wishes to use this library. BTW, none of our code outside osmo-iuh really uses those structures being used, so nothing breaks, and we don't really care if they are longer because we don't use a lot of them in any place. > > I would like to see one real-world example where we actually run into such clashes. Take osmo-iuh.git master, take osmo-hnodeb.git with all the current patches. > > IMHO, code that implements HNBAP doesn't have anything do with RANAP nor RUA. And code implementing RUA should have a clean layer separation to RANAP, too. Those are different layers, stacked on top of each other. like BSSMAP in SCCP. RUA contains an octetstring, and that octetstring contains RANAP. So being different layers means we mandate the user to use different C files and make him play tetris to make sure no headers are imported incorrectly? Why if someone wants to write a quick test/tool in one file? I see no point in mandating the use of different C files, and trying to do so just to avoid having a bit longer names goes the opposite way to what we do with other libraries, where we explicitly want to have an osmo_ prefix in order to avoid clashes with other libs. -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/25991 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I1bcbe047d233684647d6ffe9febb14a12c579696 Gerrit-Change-Number: 25991 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 29 Oct 2021 12:48:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211029/31f0dca9/attachment.htm>