This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26021 ) Change subject: Configure CI,LAC,RAC,SAC over VTY and use it in HnbRegisterRequest ...................................................................... Patch Set 1: Code-Review-1 (2 comments) CR-1 for the indention in 'show running-config'. https://gerrit.osmocom.org/c/osmo-hnodeb/+/26021/1/src/osmo-hnodeb/vty.c File src/osmo-hnodeb/vty.c: https://gerrit.osmocom.org/c/osmo-hnodeb/+/26021/1/src/osmo-hnodeb/vty.c@135 PS1, Line 135: cell_identity Do we want to inherit this inconsistency from osmo-{bsc,msc}? 'foo-bar' (preferred) 'foo_bar' 'foo bar' I vote for having one consistent naming style. https://gerrit.osmocom.org/c/osmo-hnodeb/+/26021/1/src/osmo-hnodeb/vty.c@245 PS1, Line 245: vty_out(vty, " cell_identity %u%s", g_hnb->cell_identity, VTY_NEWLINE); > you're adding one indent level here without entering a new vty node? Ack, something is wrong here. Time to add the VTY transcript tests? -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26021 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I06f21758e361b7d4d7141086d758893bee434e5c Gerrit-Change-Number: 26021 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Fri, 29 Oct 2021 05:59:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge at osmocom.org> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211029/db842de4/attachment.htm>