Change in osmo-iuh[master]: hnbap: Use asn1c flag -fcompound-names to avoid name collisions with ...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri Oct 29 05:31:40 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/25991 )

Change subject: hnbap: Use asn1c flag -fcompound-names to avoid name collisions with other libs
......................................................................


Patch Set 1:

> I'd rather have a bit longer names than really having to waste hours playing tetris with header files and source files. Having these patches solves the build problems in osmo-hnodeb and whoever wishes to use this library. BTW, none of our code outside osmo-iuh really uses those structures being used, so nothing breaks, and we don't really care if they are longer because we don't use a lot of them in any place.

I would like to see one real-world example where we actually run into such clashes. As far as I recall, I have written osmo-hnbgw without the need to do so, and I currently don't see the difference to osmo-hnodeb.

IMHO, code that implements HNBAP doesn't have anything do with RANAP nor RUA.  And code implementing RUA should have a clean layer separation to RANAP, too.  Those are different layers, stacked on top of each other.  like BSSMAP in SCCP. RUA contains an octetstring, and that octetstring contains RANAP.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/25991
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I1bcbe047d233684647d6ffe9febb14a12c579696
Gerrit-Change-Number: 25991
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Oct 2021 05:31:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211029/bc7a2a06/attachment.htm>


More information about the gerrit-log mailing list