This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25828 )
Change subject: BSC_Tests: set band in f_TC_fh_params_set
......................................................................
Patch Set 2:
(3 comments)
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25828/2/bsc/BSC_Tests.ttcn
File bsc/BSC_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25828/2/bsc/BSC_Tests.ttcn@8498
PS2, Line 8498: f_TC_set_band_by_arfcn
> Also, I believe library/ would be a better place for this function.
We have the band setting only in osmo-bsc. This is very osmo-bsc specific. It should be kept here.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25828/2/bsc/BSC_Tests.ttcn@8502
PS2, Line 8502: if (arfcn.arfcn >= 259 and arfcn.arfcn <= 293) {
> Yep, you could use 'select' here: […]
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25828/2/bsc/BSC_Tests.ttcn@8524
PS2, Line 8524: f_vty_transceive(BSCVTY, "exit");
> Just send 'end' command once instead of sending 'exit' three times.
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25828
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I447e4145c68c62b11b818e28f0081c19e9107647
Gerrit-Change-Number: 25828
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 28 Oct 2021 16:13:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211028/6f2cb7bb/attachment.htm>