This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25987 ) Change subject: l1sap: move false PTCCH/U detection into PDCH branch ...................................................................... l1sap: move false PTCCH/U detection into PDCH branch This check is only relevant for PDCH timeslots. Change-Id: I187fef8f3de0b41b502b0b18acfb11c56c5551f0 --- M src/common/l1sap.c 1 file changed, 8 insertions(+), 9 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/common/l1sap.c b/src/common/l1sap.c index 6eb08ba..d9e27b2 100644 --- a/src/common/l1sap.c +++ b/src/common/l1sap.c @@ -1494,15 +1494,6 @@ DEBUGPGT(DL1P, &g_time, "Rx PH-DATA.ind chan_nr=%s link_id=0x%02x len=%d\n", rsl_chan_nr_str(chan_nr), link_id, len); - /* Actually, there can be no DATA.ind on PTCCH/U (rather RACH.ind instead), - * but some BTS models with buggy implementation may still be sending them - * to us. Let's keep this for backwards compatibility. */ - if (L1SAP_IS_CHAN_PDCH(chan_nr) && L1SAP_IS_PTCCH(fn)) { - LOGPGT(DL1P, LOGL_NOTICE, &g_time, "There can be no DATA.ind on PTCCH/U. " - "This is probably a bug of the BTS model you're using, please fix!\n"); - return -EINVAL; - } - /* The ph_data_param contained in the l1sap primitive may contain * measurement data. If this data is present, forward it for * processing */ @@ -1525,6 +1516,14 @@ return 1; } + /* There can be no DATA.ind on PTCCH/U (rather RACH.ind instead), but some + * BTS models with buggy implementation may still be sending them to us. */ + if (L1SAP_IS_PTCCH(fn)) { + LOGPGT(DL1P, LOGL_NOTICE, &g_time, "There can be no DATA.ind on PTCCH/U. " + "This is probably a bug of the BTS model you're using, please fix!\n"); + return -EINVAL; + } + /* Drop all data from incomplete UL block */ if (pr_info != PRES_INFO_BOTH) len = 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25987 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I187fef8f3de0b41b502b0b18acfb11c56c5551f0 Gerrit-Change-Number: 25987 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211028/df2658aa/attachment.htm>