This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26005 ) Change subject: library/MNCC_EncDec.cc: fix encoding of optional 'sdp' field ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26005/2/library/MNCC_EncDec.cc File library/MNCC_EncDec.cc: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26005/2/library/MNCC_EncDec.cc@189 PS2, Line 189: strncpy(&mncc.sdp[0], sdp, sizeof(mncc.sdp)); are you sure this is the proper way to get the content? simply copying from sdp pointer and also using sizeof() looks potentially wrong to me. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26005 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I82f8afd3e64d83d165a7070a1b82a6276ef0b020 Gerrit-Change-Number: 26005 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 28 Oct 2021 14:07:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211028/e1f398eb/attachment.htm>