Change in osmo-bsc[master]: bsc_ctrl_commands: add ctrl command to resend system information

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Thu Oct 28 08:24:13 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25829 )

Change subject: bsc_ctrl_commands: add ctrl command to resend system information
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/25829/3/src/osmo-bsc/bsc_ctrl_commands.c 
File src/osmo-bsc/bsc_ctrl_commands.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/25829/3/src/osmo-bsc/bsc_ctrl_commands.c@670 
PS3, Line 670: static int set_bts_resend_si(struct ctrl_cmd *cmd, void *data)
> Not that I object at all, but this is basically code duplication of lines 276-290
Ok, thats interesting, its even documented: bts.N.send-new-system-informations, but the description "Regenerate SystemInformation messagesfor given BTS" does not make clear that the sysinfo is also resent. That probably means that this can be abandoned.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25829
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Id628fc6f0771de67f60cbc96b631000b04c765f4
Gerrit-Change-Number: 25829
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 28 Oct 2021 08:24:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: keith <keith at rhizomatica.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211028/57152071/attachment.htm>


More information about the gerrit-log mailing list