Change in osmo-bsc[master]: heighbor_ident: add/del neighbor cells via ctrl interface

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25976 )

Change subject: heighbor_ident: add/del neighbor cells via ctrl interface
......................................................................


Patch Set 3:

(4 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/25976/3/doc/manuals/chapters/control.adoc 
File doc/manuals/chapters/control.adoc:

https://gerrit.osmocom.org/c/osmo-bsc/+/25976/3/doc/manuals/chapters/control.adoc@124 
PS3, Line 124: FIXME: add variables defined in src/ctrl/control_if.c?
This FIXME probably needs to be kept at the end.


https://gerrit.osmocom.org/c/osmo-bsc/+/25976/3/src/osmo-bsc/neighbor_ident_ctrl.c 
File src/osmo-bsc/neighbor_ident_ctrl.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/25976/3/src/osmo-bsc/neighbor_ident_ctrl.c@28 
PS3, Line 28: #include <osmocom/vty/command.h>
why are these vty headers needed here?


https://gerrit.osmocom.org/c/osmo-bsc/+/25976/3/src/osmo-bsc/neighbor_ident_ctrl.c@121 
PS3, Line 121: CTRL_CMD_DEFINE_WO(neighbor_bts_add, "neighbor-bts add");
Please add some documentation here on the expected format regarding params, etc. for each command.


https://gerrit.osmocom.org/c/osmo-bsc/+/25976/3/tests/ctrl_test_runner.py 
File tests/ctrl_test_runner.py:

https://gerrit.osmocom.org/c/osmo-bsc/+/25976/3/tests/ctrl_test_runner.py@655 
PS3, Line 655:         r = self.do_set('bts.0.neighbor-cgi.add', '001-01-100-200-123-4')
This kind of stuff is what you need to add as a comment before definining each CTRL command, explaining what each param is.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25976
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I343a40e18fa9b91e6c381912c0426a002841e079
Gerrit-Change-Number: 25976
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 27 Oct 2021 14:04:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211027/3854c8dc/attachment.htm>