Change in osmo-cbc[master]: varaible for atoi() result shouild be signed integer

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Wed Oct 27 12:12:34 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/25931 )

Change subject: varaible for atoi() result shouild be signed integer
......................................................................

varaible for atoi() result shouild be signed integer

... otherwise we won't detect < 0 cases.

Fixes: CID#240731
Change-Id: I650fce5bd64752823ee57d8b528d2b371fada857
---
M src/rest_api.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/rest_api.c b/src/rest_api.c
index c70d096..52bf25e 100644
--- a/src/rest_api.c
+++ b/src/rest_api.c
@@ -602,7 +602,7 @@
 {
 	const char *message_id_str = u_map_get(req->map_url, "message_id");
 	struct rest_it_op *riop = talloc_zero(g_cbc, struct rest_it_op);
-	uint16_t message_id;
+	int message_id;
 	int status = 404;
 	int rc;
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/25931
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: I650fce5bd64752823ee57d8b528d2b371fada857
Gerrit-Change-Number: 25931
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211027/a5a6e3cb/attachment.htm>


More information about the gerrit-log mailing list