Change in osmo-bts[master]: scheduler: Avoid crash upon call to trx_sched_set_lchan if l1ts is un...

[pespin]

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/25966 )


Change subject: scheduler: Avoid crash upon call to trx_sched_set_lchan if l1ts is uninitialized
......................................................................

scheduler: Avoid crash upon call to trx_sched_set_lchan if l1ts is uninitialized

It could happen if for instance l1 code called trx_sched_clean() when
closing the phy, and after that some code called (erroneously)
trx_sched_set_lchan(). Let's make sure we don't allow other modules to
crash the process when using this function.

Related: SYS#4971
Change-Id: I93af7c3dcf0e34e9317eec0ee183dbf18b8d2f3b
---
M src/common/scheduler.c
1 file changed, 6 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/66/25966/1

diff --git a/src/common/scheduler.c b/src/common/scheduler.c
index c068ea0..0388445 100644
--- a/src/common/scheduler.c
+++ b/src/common/scheduler.c
@@ -1085,6 +1085,12 @@
 	bool found = false;
 	int i;
 
+	if (!l1ts) {
+		LOGPLCHAN(lchan, DL1C, LOGL_ERROR, "%s lchan with uninitialized scheduler structure\n",
+			  (active) ? "Activating" : "Deactivating");
+		return -EINVAL;
+	}
+
 	/* VAMOS: convert Osmocom specific channel number to a generic one,
 	 * otherwise we won't match anything in trx_chan_desc[]. */
 	if (lchan->ts->vamos.is_shadow)

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25966
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I93af7c3dcf0e34e9317eec0ee183dbf18b8d2f3b
Gerrit-Change-Number: 25966
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211026/5e4e19c3/attachment.htm>