This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25947 ) Change subject: Set subslots_per_pchan_vamos[GSM_PCHAN_OSMO_DYN] = 0 ...................................................................... Set subslots_per_pchan_vamos[GSM_PCHAN_OSMO_DYN] = 0 VAMOS secondary lchans are to be used specifically when the osmocom dyn TS is set to pchan_is=TCH_{F,H}. Setting secondary subslots for OSMO_DYN TS is not needed since it's only used to initialize the TS, and OSMO DYN already initializes 8 subslots (subslots_per_pchan[GSM_PCHAN_OSMO_DYN]=8). Otherwise, ts_setup_lchans() will try to initialize 8+2 lchans on the TS, which is more than needed and will access out of bounds in the array. Related: OS#5278 Change-Id: I8727d5b446179c0ebcd8738507efe5a50afaf1e2 --- M src/osmo-bsc/gsm_data.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/osmo-bsc/gsm_data.c b/src/osmo-bsc/gsm_data.c index b0e0a68..0134e34 100644 --- a/src/osmo-bsc/gsm_data.c +++ b/src/osmo-bsc/gsm_data.c @@ -633,7 +633,7 @@ [GSM_PCHAN_SDCCH8_SACCH8C] = 0, [GSM_PCHAN_CCCH_SDCCH4_CBCH] = 0, [GSM_PCHAN_SDCCH8_SACCH8C_CBCH] = 0, - [GSM_PCHAN_OSMO_DYN] = 2, + [GSM_PCHAN_OSMO_DYN] = 0, [GSM_PCHAN_TCH_F_PDCH] = 2, }; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25947 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8727d5b446179c0ebcd8738507efe5a50afaf1e2 Gerrit-Change-Number: 25947 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211026/bba302fb/attachment.htm>