This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25946 ) Change subject: timeslot_fsm: Add assert to make sure we never go out of bounds in ts->lchan array ...................................................................... timeslot_fsm: Add assert to make sure we never go out of bounds in ts->lchan array Related: OS#5278 Change-Id: I23a5349838e0c540fbb54cad10f2af42268d7729 --- M src/osmo-bsc/timeslot_fsm.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/osmo-bsc/timeslot_fsm.c b/src/osmo-bsc/timeslot_fsm.c index 76ac1af..93fc380 100644 --- a/src/osmo-bsc/timeslot_fsm.c +++ b/src/osmo-bsc/timeslot_fsm.c @@ -243,6 +243,7 @@ ts->max_lchans_possible = max_lchans + max_lchans_vamos; ts->max_primary_lchans = 0; + OSMO_ASSERT(ts->max_lchans_possible <= TS_MAX_LCHAN); for (i = 0; i < ts->max_lchans_possible; i++) { /* If we receive more than one Channel OPSTART ACK, don't fail on the second init. */ if (ts->lchan[i].fi) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25946 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I23a5349838e0c540fbb54cad10f2af42268d7729 Gerrit-Change-Number: 25946 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211026/800fe5b5/attachment.htm>