Change in osmo-bts[master]: bts-trx: sched: tx_pdtch_fn: Handle PCU idle blocks properly

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25942 )

Change subject: bts-trx: sched: tx_pdtch_fn: Handle PCU idle blocks properly
......................................................................

bts-trx: sched: tx_pdtch_fn: Handle PCU idle blocks properly

PCU idle blocks are identified by being 0 length, and hence msg->l2h
being null. Don't try to encode those, but simply discard them silently.

In case there's a missing block in C0, we want to log the event since
the BTS is expected to send something on C0.

Related: SYS#5676
Related: SYS#4919
Fixes: 300e31ed135c674cd44526b7503d4664a45a9ec3
Change-Id: I57e215fedeb415db4e67fdc56bf0f1410b5f7130
---
M src/osmo-bts-trx/sched_lchan_pdtch.c
1 file changed, 5 insertions(+), 2 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bts-trx/sched_lchan_pdtch.c b/src/osmo-bts-trx/sched_lchan_pdtch.c
index 4c63acb..e9e1e82 100644
--- a/src/osmo-bts-trx/sched_lchan_pdtch.c
+++ b/src/osmo-bts-trx/sched_lchan_pdtch.c
@@ -32,6 +32,7 @@
 #include <osmo-bts/logging.h>
 #include <osmo-bts/scheduler.h>
 #include <osmo-bts/scheduler_backend.h>
+#include <osmo-bts/bts_trx.h>
 
 #include <sched_utils.h>
 
@@ -161,8 +162,10 @@
 
 	/* get mac block from queue */
 	msg = _sched_dequeue_prim(l1ts, br);
-	if (!msg) {
-		LOGL1SB(DL1P, LOGL_INFO, l1ts, br, "No prim for transmit.\n");
+	if (!msg  || !msg->l2h) {
+		const struct gsm_bts_trx *trx = l1ts->ts->trx;
+		if (!msg  || trx == trx->bts->c0)
+			LOGL1SB(DL1P, LOGL_INFO, l1ts, br, "No prim for transmit.\n");
 		goto no_msg;
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25942
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I57e215fedeb415db4e67fdc56bf0f1410b5f7130
Gerrit-Change-Number: 25942
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211025/3d782e66/attachment.htm>