Change in osmo-msc[master]: smpp_smsc: use osmo_talloc_replace_string() in smpp_smsc_conf()

[fixeria]

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/25930 )


Change subject: smpp_smsc: use osmo_talloc_replace_string() in smpp_smsc_conf()
......................................................................

smpp_smsc: use osmo_talloc_replace_string() in smpp_smsc_conf()

Change-Id: Ie3dc0d9673a0410a5908cba77fc352d581bac6f6
Fixes: CID#240711
---
M src/libmsc/smpp_smsc.c
1 file changed, 1 insertion(+), 7 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/30/25930/1

diff --git a/src/libmsc/smpp_smsc.c b/src/libmsc/smpp_smsc.c
index a5c6165..503a279 100644
--- a/src/libmsc/smpp_smsc.c
+++ b/src/libmsc/smpp_smsc.c
@@ -987,14 +987,8 @@
 	/* Avoid use-after-free if bind_addr == smsc->bind_addr */
 	if (smsc->bind_addr == bind_addr)
 		return 0;
+	osmo_talloc_replace_string(&smsc->bind_addr, bind_addr);
 
-	talloc_free((void*)smsc->bind_addr);
-	smsc->bind_addr = NULL;
-	if (bind_addr) {
-		smsc->bind_addr = bind_addr ? talloc_strdup(smsc, bind_addr) : NULL;
-		if (!smsc->bind_addr)
-			return -ENOMEM;
-	}
 	return 0;
 }
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/25930
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ie3dc0d9673a0410a5908cba77fc352d581bac6f6
Gerrit-Change-Number: 25930
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211024/9b604481/attachment.htm>